This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Add Account.declare #207
Merged
Add Account.declare #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martriay
requested review from
andrew-fleming,
ericglau and
ericnordelo
and removed request for
ericnordelo,
ericglau and
andrew-fleming
ericglau
reviewed
Sep 23, 2022
Co-authored-by: Andrew Fleming <[email protected]>
… into account-declare-deploy
andrew-fleming
previously approved these changes
Sep 24, 2022
ericglau
reviewed
Sep 26, 2022
ericglau
reviewed
Sep 27, 2022
ericglau
reviewed
Sep 27, 2022
ericnordelo
reviewed
Oct 3, 2022
|
The |
ericnordelo
reviewed
Oct 19, 2022
andrew-fleming
previously approved these changes
Oct 21, 2022
martriay
dismissed stale reviews from andrew-fleming and ericnordelo
via
c65d8ac
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186, #205.
run_commandso it actually centralizes starknet CLI calls.nile.core.declare.get_hashwhich takes acontract_classand returns its hash (see Improve howdeclarehandles an existing class hash #205).Account.deploy_contractwhich relies on a Deployer Contract to deploy, which eludes our deployments tracking/management system. I think we need to rethink its model, but probably in a different issue/PR.